Skip to content

fall through if PRM endpoint is not implemented #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fall through if PRM endpoint is not implemented #1562

wants to merge 1 commit into from
+0 −2

Conversation

@dogacancolak
Copy link
Contributor

@dogacancolak dogacancolak commented Oct 31, 2025 •
edited
Loading

Motivation and Context

As raised in #1495, one of the changes in #1324 included raising an error if PRM endpoint request failed. This caused backwards compatibility issues with MCP servers that haven't yet added support for PRM

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@maxisbey maxisbey added needs more eyes Needs alignment among maintainers whether this is something we want to add auth Issues and PRs related to Authentication / OAuth P1 Significant bug affecting many users, highly requested feature labels Nov 4, 2025
maxisbey
maxisbey requested changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@maxisbey maxisbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you please add a unit test for this which would fail before the fix and pass with your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxisbey maxisbey maxisbey requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

auth Issues and PRs related to Authentication / OAuth needs more eyes Needs alignment among maintainers whether this is something we want to add P1 Significant bug affecting many users, highly requested feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dogacancolak @maxisbey